Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto-detect package manager in create fuels #3503

Merged
merged 13 commits into from
Jan 2, 2025
Merged

feat: auto-detect package manager in create fuels #3503

merged 13 commits into from
Jan 2, 2025

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Dec 26, 2024 •
edited by petertonysmith94
Loading

Release notes

In this release, we:

  • Added auto-detection for the user's package manager of choice for create fuels

Summary

create fuels now auto-detects the user's package manager. eg. bun create fuels will now use bun to install dependencies.

Breaking Changes

  • Removed the package manager flags from create fuels CLI`
// Before
npm create fuels -- --npm
bun create fuels --bun
pnpm create fuels --pnpm
// After
npm create fuels
bun create fuels
pnpm create fuels

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:30pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:30pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:30pm

@github-actions github-actions bot added the feat Issue is a feature label Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-3503-20241226031927

@Dhaiwat10 Dhaiwat10 self-assigned this Dec 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3503 will degrade performances by 48.61%

Comparing dp/create-fuels-pkg-manager (6f3b3f9) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dp/create-fuels-pkg-manager Change
❌ should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 97.8 ms -48.61%

@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review December 26, 2024 03:22
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) December 26, 2024 12:48
danielbate
danielbate previously approved these changes Dec 30, 2024
View reviewed changes
@Dhaiwat10 @petertonysmith94
update bun command
91b4f74 
Co-authored-by: Peter Smith <[email protected]>
@Dhaiwat10 @petertonysmith94
update bun command
73a8523 
Co-authored-by: Peter Smith <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Coverage Report:

Lines Branches Functions Statements
77.78%(-0.05%) 70.4%(-0.15%) 75.37%(-0.13%) 77.74%(-0.05%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/predicate/predicate.ts 24.61%
(+2.03%)		 24.24%
(-4.33%)		 10%
(-0.52%)		 23.18%
(+1.97%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)
🔴 packages/address/src/address.ts 91.07%
(+0.91%)		 86.66%
(+6.11%)		 85.71%
(+0%)		 91.22%
(+0.9%)
🔴 packages/address/src/utils.ts 78.26%
(-6.11%)		 71.42%
(-7.52%)		 87.5%
(-4.8%)		 79.16%
(-5.68%)
🔴 packages/create-fuels/src/lib/getPackageManager.ts 100%
(+0%)		 88.88%
(+8.88%)		 100%
(+0%)		 100%
(+0%)
🔴 packages/logger/src/index.ts 82.85%
(-0.93%)		 76.92%
(-3.08%)		 50%
(-2.38%)		 77.5%
(-1.07%)

@Dhaiwat10 Dhaiwat10 merged commit e8a8c71 into master Jan 2, 2025
23 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-pkg-manager branch January 2, 2025 13:33
@fuel-service-user fuel-service-user mentioned this pull request Jan 2, 2025
Open
arboleya added a commit that referenced this pull request Jan 3, 2025
@arboleya
Revert "feat: auto-detect package manager in create fuels (#3503)"
be53f89 
This reverts commit e8a8c71.
@arboleya arboleya mentioned this pull request Jan 3, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-detect package manager in create fuels
4 participants
@Dhaiwat10 @danielbate @petertonysmith94 @nedsalk